Create and install a BridgeDescMgr when we bootstrap

Fixes #631 (closed).

assigned to @Diziet

requested review from @nickm

Note to self: Why was this Optional in the first place?

Note that you made this an Option in 2d3f4493, and said:

arti-client: Make dormant_mode be an Option, None on drop

This will allow receivers (which we are about to introduce) to terminate when the last client is dropped.

Will the change in this commit break this behavior?

changed this line in version 2 of the diff

Investigating Option issue.

FYI, CI is failing. Once it's passing I think this is okay to merge.

Actually, please double-check the Option issue and the commit mentioned above.

That change was nonsense. Well spotted.

added 3 commits

• da2c4b60 - Revert "arti_client: dormancy: Remove a pointless Option"
• e8b73670 - fixup! bridges: Create and install a BridgeDescMgr when we bootstrap
• c41c3d60 - fixup! bridges: Create and install a BridgeDescMgr when we bootstrap

Compare with previous version

marked this merge request as draft from Diziet/arti@e8b73670

mentioned in commit Diziet/arti@1042f9ae

mentioned in merge request !853 (merged)

I hope I have fixed the CI too.

Looks good, except please also add a comment to explain why DormantMode has to be in an Option<·>. After that feel free to squash and merge.

mentioned in commit Diziet/arti@4fd1b732

I've proposed a way to avoid this Option bug being possible in !853 (merged), and added a comment there: !853 (4fd1b732)

added 11 commits

• c41c3d60...79a09ae3 - 5 commits from branch tpo/core:main
• 76ed10ef - arti_client: dormancy: Remove a pointless Option
• 9475d7f5 - arti-client: Store a handle to the guardmgr in TorClient
• c76ee47b - arti-client: Store a handle to the DirMgrStore in TorClient
• 528ae180 - arti-client: Store a handle to the DirMgrStore in TorClient (fmt)
• a4a738c0 - bridges: Create and install a BridgeDescMgr when we bootstrap
• 99093759 - Revert "arti_client: dormancy: Remove a pointless Option"

Compare with previous version

added 4 commits

• 647610f2 - arti-client: Store a handle to the guardmgr in TorClient
• 63c46394 - arti-client: Store a handle to the DirMgrStore in TorClient
• a565e338 - arti-client: Store a handle to the DirMgrStore in TorClient (fmt)
• b7441c98 - bridges: Create and install a BridgeDescMgr when we bootstrap

Compare with previous version

marked this merge request as ready

enabled an automatic merge when the pipeline for b7441c98 succeeds

CI failure was docker related; I've hit "retry".

merged

mentioned in commit 88caacfb

mentioned in commit Diziet/arti@de0c12df

mentioned in commit Diziet/arti@ddd48c50

mentioned in commit Diziet/arti@c82cda85

mentioned in commit Diziet/arti@4d502bd8