Also add implementation details and a timestampt to the output of 161.

If we ever add an event, then set it, then add it again, there will be
now two pointers to the event in the event base.  If we delete one and
free it, the first pointer will still be there, and possibly cause a
crash later.

This patch adds detection for this case to the code paths in
eventdns.c, and works around it.  If the warning message ever
displays, then a cleverer fix is in order.

{I am not too confident that this *is* the fix, since bug 957 is very
tricky.  If it is, it is a bugfix on 0.2.0.}

Roger Dingledine authored 15 years ago and Nick Mathewson committed 15 years ago

and cert from disk. Bugfix on 0.2.0.1-alpha.

When we got a descriptor that we (as an authority) rejected as totally
bad, we were freeing it, then using the digest in its RAM to look up its
download status.  Caught by arma with valgrind.  Bugfix on 0.2.1.9-alpha.

The trick is that we should assert that our next_mem pointer has not
run off the end of the array _before_ we realign the pointer, since
doing that could take us over the end... but only if we're on a system
where malloc() gives us ram in increments smaller than sizeof(void*).

The big changes are to go from a "caches compute the micro-descriptor"
format to an "authorities generate microdescriptors" format.

See or-dev discussions of January 2009 for full rationales.

Karsten Loesing authored 15 years ago and Nick Mathewson committed 15 years ago

Bridges are not supposed to publish router descriptors to the directory
authorities. It defeats the point of bridges when they are included in the
public relay directory.

This patch puts out a warning and exits when the node is configured as
a bridge and to publish v1, v2, or v3 descriptors at the same time.

Also fixes part of bug 932.

This fixes bug 932, where all of our usage totals for users when we
were a regular server would get included in the extrainfo document.

This matters because a cpuworker can close its socket when it
finishes.  Cpuworker typically runs in another thread, so without a
lock here, we can have a race condition and get confused about how
many sockets are open.  Possible fix for bug 939.

This might detect some possible causes of bug 930, and will at least
make sure we aren't doing some dumb memory-corruption stuff with the heap
and router-parsing.

This addresses the first part of bug 918. Users are now warned when
they try to use hibernation in combination with a port below 1024
when they're not on Windows. We don't want to die here, because
people might run Tor as root, use a capabilities system or some
other platform that will allow them to re-attach low ports.

Wording suggested by Marian

Manually resolved conflicts on version number; all else applied cleanly.

(Don't crash immediately if we have leftover chunks to free after
freeing chunks in a buffer freelist; instead log a debugging message
that might help.)

(Proposals assigned to others are purely in the realm of speculation.)

We don't need to explain the difference between 2nd preimage and
collision: anybody who doesn't know can use wikipedia.

This way we do not need to rebuild util.c and/or config.c whenever
any unrelated source file in src/common or src/or has changed.