- Dec 13, 2022
-
-
Ben Hearsum authored
Bug 1804449: document basic information about update infrastructure and watershed updates in the source docs. r=jcristau Differential Revision: https://phabricator.services.mozilla.com/D164493
-
Jan de Mooij authored
Now that `replaceShape` also works for dictionary shapes, we don't need the `isShared` check anymore. Depends on D164572 Differential Revision: https://phabricator.services.mozilla.com/D164575
-
Jan de Mooij authored
Adds a constructor that takes the object for which we want to create a new shape, so that we can get rid of some roots. Differential Revision: https://phabricator.services.mozilla.com/D164572
-
Jan de Mooij authored
This makes the code for dictionary shapes more similar to the other shapes and simplifies the callers. It's also more efficient because instead of cloning the shape and then mutating it, the new shape now has the right contents from the start. Differential Revision: https://phabricator.services.mozilla.com/D164571
-
Benjamin VanderSloot authored
Differential Revision: https://phabricator.services.mozilla.com/D164073
-
Ray Kraesig authored
Bug 1772908 - [6/6] Replace polling in UpdateDriver with use of HandleWatcher on Windows r=application-update-reviewers,bytesized On Windows and on most flavors of Unix (including Linux, but explicitly excluding macOS), when we wait for an updater-process to terminate, we poll for its completion rather than reacting asynchronously to some OS-provided event. The polling loop is _supposed_ to be async-friendly and interruptible, in that it enqueues its continuation onto its thread's event queue, rather than directly and synchronously looping. Unfortunately, the polling loop doesn't idle between poll attempts. Instead, it calls `sleep()` (or the moral equivalent) directly within the posted task, and then enqueues its next continuation at the default priority before concluding. Since shutdown-time teardown is effectively an idle-priority task, it will never get to run unless the updater finishes — so an active updater process will always induce a shutdown hang. The best fix for this is almost certainly to just _not_ poll, and instead set up some listener for whatever asynchronous mechanism each OS provides for this sort of thing. For Windows, use `HandleWatcher` to do exactly that. (For other OSes, kick the can down the road.) Differential Revision: https://phabricator.services.mozilla.com/D159563
-
Ray Kraesig authored
Implement a version of Chromium's `base::ObjectWatcher` which does not rely on the Chromium MessageLoop. Differential Revision: https://phabricator.services.mozilla.com/D159562
-
Byron Campen authored
Differential Revision: https://phabricator.services.mozilla.com/D156837
-
Byron Campen authored
Bug 1401592: Add a config option to imitate the old setParameters behavior. r=jib,chutten,webidl,smaug When the compat mode is used, we log warnings to the JS console instead of throwing. We also add a bunch of Glean metrics for tracking how often we see these warnings (or failures) in the field. Differential Revision: https://phabricator.services.mozilla.com/D161523
-
Byron Campen authored
Differential Revision: https://phabricator.services.mozilla.com/D157657
-
Byron Campen authored
Bug 1401592: Test that sRD with a single rid results in [[SendEncodings]] containing that rid. r=jib Differential Revision: https://phabricator.services.mozilla.com/D157656
-
Byron Campen authored
Differential Revision: https://phabricator.services.mozilla.com/D157655
-
Byron Campen authored
Bug 1401592: Restore old ridless unicast encoding when JSEP rolls back an initial simulcast offer. r=mjf Differential Revision: https://phabricator.services.mozilla.com/D157654
-
Byron Campen authored
Differential Revision: https://phabricator.services.mozilla.com/D157653
-
Byron Campen authored
Differential Revision: https://phabricator.services.mozilla.com/D157651
-
Byron Campen authored
Differential Revision: https://phabricator.services.mozilla.com/D157650
-
Byron Campen authored
Here we adopt the strategy used for sRD(offer) racing against addTrack; when the race is detected, the sRD is restarted. We also clear [[LastReturnedParameters]] when sRD or sLD(answer) finishes, according to the spec. Differential Revision: https://phabricator.services.mozilla.com/D156836
-
Byron Campen authored
Also adds some helper code based on the helper code in wpt. Differential Revision: https://phabricator.services.mozilla.com/D156835
-
Byron Campen authored
Bug 1401592: Support sendEncodings in addTransceiver, and bring get/setParameters up to spec. r=mjf,webidl,smaug Also, fix a pre-existing bug in JsepTrack::operator= Differential Revision: https://phabricator.services.mozilla.com/D156834
-
Byron Campen authored
There is not really any reason to support disabling this feature. Differential Revision: https://phabricator.services.mozilla.com/D156833
-
Byron Campen authored
Includes a configured max rid length, since it is not very reasonable to assume that rids of length 255 are supported by the RTP engine, regardless of what the IETF specs say. Differential Revision: https://phabricator.services.mozilla.com/D156832
-
Byron Campen authored
JsepTrack used to be in charge of this, but because JSEP doesn't negotiate encoding constraints, it did not make sense to delegate this to the JSEP code. Differential Revision: https://phabricator.services.mozilla.com/D156831
-
Byron Campen authored
The spec has settled on not allowing these constraints to be negotiated, so all that is left is the negotiation of the set of rids. Also, add an include to eliminate some bot spam. Differential Revision: https://phabricator.services.mozilla.com/D156830
-
Byron Campen authored
Differential Revision: https://phabricator.services.mozilla.com/D156829
-
Byron Campen authored
Differential Revision: https://phabricator.services.mozilla.com/D156828
-
David Shin authored
Previously, when current overflow area has one axis at zero size, calling `OverflowAreas::Union*` with a rect with both axes at zero would overwrite the axis with non-zero size. Differential Revision: https://phabricator.services.mozilla.com/D162245
-
Greg Tatum authored
The HOST_NAME could be undefined if the URL is not valid and throws. The broader functions that use it would still be defined due to hoisting. Differential Revision: https://phabricator.services.mozilla.com/D164462
-
Kershaw Chang authored
Differential Revision: https://phabricator.services.mozilla.com/D164449
-
Nicolas Silva authored
Differential Revision: https://phabricator.services.mozilla.com/D162305
-
Paul Adenot authored
Differential Revision: https://phabricator.services.mozilla.com/D163721
-
Paul Adenot authored
Differential Revision: https://phabricator.services.mozilla.com/D163720
-
Bernard Igiri authored
Bug 1799393 - Prevent hidden Fx View tab from triggering the closing multiple tabs warning in Windows and Linux r=Gijs Updated the tab closing prompt logic to use the number of visible tabs open to determine if the prompt should show in Windows and Linux. Differential Revision: https://phabricator.services.mozilla.com/D162627
-
Nazım Can Altınova authored
Differential Revision: https://phabricator.services.mozilla.com/D163714
-
Gijs Kruitbosch authored
This prevents the issue described in the bug in two ways: - avoid attempting to start a connection in shutdown - call connection.close() even if we fail to add a shutdown blocker. It does both because if we did only the first, we would still have a potential race where when _getConnection is called, we would not be in shutdown, but by the time we try to close the connection, we could be. If we only did the second, we'd keep retrying which is also bad. Differential Revision: https://phabricator.services.mozilla.com/D163225
-
Stanca Serban authored
Backed out changeset 270d2dcb215c (bug 1800422) for causing bustages in CookieBannerDomainPrefService.cpp. CLOSED TREE
-
Alex Ionescu authored
Differential Revision: https://phabricator.services.mozilla.com/D164437
-
Sylvestre Ledru authored
Bug 1803331 - skia/generator: refresh the list to have the up to date moz.build after running generate_mozbuild.py r=nical DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D163813
-
Jens Stutte authored
Differential Revision: https://phabricator.services.mozilla.com/D164552
-
Geoff Brown authored
Bug 1805306 - Allow retrieval of compressed config files in final-verification.sh r=jcristau DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D164534
-
Sylvestre Ledru authored
Differential Revision: https://phabricator.services.mozilla.com/D164566
-