Rebrand Tor Browser's Window's Installer

The windows NSIS installer could use some rebranding as well!

TODO per build (stable, alpha, nightly):

• icon
• default install path and shortcut name (to allow side-by-side installation)
• release-
  $OS-$
  ARCH -> 'Tor Browser'
• alpha-
  $OS-$
  ARCH -> 'Tor Browser Alpha'
• nightly-
  $OS-$
  ARCH -> 'Tor Browser Nightly'

added TorBrowserTeam201901R in Legacy / Trac component::applications/tor browser in Legacy / Trac owner::pospeselr in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::project in Legacy / Trac labels

Trac:
Summary: Rebrand Tor Browser's Installer to Rebrand Tor Browser's Window's Installer

Trac:
28546_00.patch

Trac:

These patches update the branding for tor-browser's windows NSIS installer. The new channel specific icons are used and the default install path and shortcuts include the channel name to allow side-by-side installations. The shortcut name has also been changed from 'Start Tor Browser' to:

• release -> 'Tor Browser.lnk'
• nightly -> 'Tor Browser Nightly.lnk'
• alpha -> 'Tor Browser Alpha.lnk'

---

tbb-windows-installer patch (I don't seem to have a tbb-windows-installer gitweb): https://trac.torproject.org/projects/tor/raw-attachment/ticket/28546/28546_02.patch

tor-browser-build change: https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_28546

EDIT: Updated the icons used with less-squashed versions from legacy/trac#25702 (moved)

Trac:
Status: assigned to needs_review
Cc: tbb-team to tbb-team, antonela
Keywords: N/A deleted, TorBrowserTeam201811R added

\o/ looks great! thanks pospeselr!

Move review tickets to Decemeber.

Trac:
Keywords: TorBrowserTeam201811R deleted, TorBrowserTeam201812R added

Moving review tickets to 2019.

Trac:
Keywords: TorBrowserTeam201812R deleted, TorBrowserTeam201901R added

Trac:
28546_01.patch

Trac:
28546_02.patch

Trac:
Parent: legacy/trac#25702 (moved) to N/A

I tested this patch with release and nightly builds, and it looks good to me.

I opened a pull request to merge the patch to upstream git repo: https://github.com/moba/tbb-windows-installer/pull/4

Replying to pospeselr:

tor-browser-build change: https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_28546

I cherry-picked this commit, and added the tbb-windows-installer version change, and pushed this as commit 031ecd732636c627ea3b6343869d96ccbf3d2df0.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

FWIW, we needed to back this out for the 8.5a7 release due to legacy/trac#29185 (moved). No reopening necessary as we deal with re-landing the patch there as well.

closed

mentioned in issue legacy/trac#28809 (moved)

mentioned in issue legacy/trac#28810 (moved)

mentioned in issue legacy/trac#29185 (moved)

moved from legacy/trac#28546 (moved)

added Project label and removed 1 deleted label

removed 1 deleted label

mentioned in issue tor-browser-build#29185 (closed)

reopened

@richard @donuts we've spoken about this somewhere a few days ago, and then a cypherpunk reminded us of this issue in a related one.

So, I'm reopening it, since I have closed #29185 without including the rebrand.

added Next label

added Feature label

added Windows label

@donuts @nicob if you have some free cycles could we get tor-browser installer icons (similar to the Sponsor 131 icons you've already done ) for 12.5 this summer?

We actually have one already that I developed at the same time - but I can create a ticket to track on the branding end for any refinements we might need. Would we need an installer icon for nightly and alpha too?

We should finalize the refreshed application icons first, but yep – 12.5 sounds good!

@nicob yep separate ones for alpha and nighty too :)

@donuts if we have the assets for this floating around it's easy enough to integrate into our new installers. Otherwise we can kick to 13.5 stable

marked this issue as related to tor-browser-build#40730 (closed)

removed Next label

added Roadmap::Future label

marked this issue as related to #41658 (closed)

Let's push this back to 13.0

added 13.0 stable label

removed the relation with tor-browser-build#40730 (closed)

marked this issue as related to #41956 (closed)

added Sponsor 131 label

assigned to @pierov and unassigned @richard

removed 13.0 stable label

removed Roadmap::Future label

added Needs Information label

assigned to @donuts and unassigned @pierov

This was done in #41658 (closed).

closed