I'm not sure our custom onion site errors are useful enough to justify maintaining a separate template over the standard neterror template. Let's do a little design exploration to see how they'd look in the new neterror template introduced in ESR 115 instead.
@donuts here's a first pass at it. It now uses the new template styles including the "What can you do about it?" section. I imagine this would need a little bit of copy work, but hopefully it simplifies the code a little. What do you think? (Figma link)
Authentication requiredOnionsite not foundInvalid onionsite
It feels a lot clearer to me. I totally get the intention behind the three icons in the current template, but in practice I think they're distracting from the message itself.
I'm also 100% in favor of your content amends, but I think we should limit the scope of this task as a simple template change for now, so the devs can reuse the current H1s and body text wholesale. In the future it would be great to review and iterate on the content itself for each of these errors as part of the wider work going on to improve the usability of onion services.
Adding or removing buttons and support links is less problematic however :)
Some very small housekeeping things:
The chrome should be in its "ready" state in this case (i.e. no Connection status label).
The primary button appears to be set to light theme – can you switch it to dark here?
Could you swap the icon to use the full contrast color scheme please? FYI I've renamed these variables in the library so they're more agnostic – icon/firefox is now icon/color and icon/onion is now icon/deemphasized. Hopefully I didn't break anything!
@donuts I've historically ignored the three icons when I run into onion service issues, so I'm all for it!
I could imagine an alternate route of improving on the visuals like adding colors, but this has an added benefit of making our work and dev's work easier.
@pierov true alright I adjusted to just show the error title and short description. It's looking a little sparse, but perhaps that's something that we can expand on it with some copywriting work.
Just got to this. Thank you @richard! @donuts since this is already in the 13.5 file it looks I could add annotations for the devs and then I can close this out?
Let's keep this one open and assign it over to dev for implementation please. That can be @richard until they decide who'll take it on for the 13.5 release cycle.
@donuts I've mostly put this together. The full list of errors we have is
Onionsite Not Found
The most likely cause is that the onionsite is offline. Contact the onionsite administrator.
Onionsite Cannot Be Reached
The onionsite is unreachable due an internal error.
Onionsite Has Disconnected
The most likely cause is that the onionsite is offline. Contact the onionsite administrator.
Unable to Connect to Onionsite
The onionsite is busy or the Tor network is overloaded. Try again later.
Onionsite Requires Authentication
Access to the onionsite requires a key but none was provided.
Onionsite Authentication Failed
The provided key is incorrect or has been revoked. Contact the onionsite administrator.
Invalid Onionsite Address
The provided onionsite address is invalid. Please check that you entered it correctly.
Onionsite Circuit Creation Timed Out
Failed to connect to the onionsite, possibly due to a poor network connection.
The mockups include both "Try Again" (primary/recommended) and "Go Back". But the mozilla net error pages only ever show one or the other, and only shows "Go Back" as primary. In particular, I think it only shows "Go Back" if it might be a bad idea to proceed to the web page for security reasons. As such, mozilla does not really support showing both, so it would have to be something we add ourselves.
Is there any particular reason we want the "Go Back" button within the net error page, when it isn't a recommended action? Otherwise it would be much simpler to only show "Try Again".
Do we want any different buttons for the above onionsite errors?