Skip to content
Snippets Groups Projects

Refactor the tor-rtcompat API.

Merged Nick Mathewson requested to merge nickm/arti:rtcompat-refactor into main

This branch provides a more uniform API for constructing and running Runtime instances that use Tokio or AsyncStd and NativeTls or Rustls.

It also makes the NativeTls runtime optional, and gets rid of a whole bunch of duplicated and/or boilerplate code.

I recommend reviewing one commit at a time.

Closes #300 (closed).

Closes #301 (closed).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • eta
  • eta
  • eta
  • eta
  • eta
    • Contributor

      Nice work; I think these changes make the crate a lot more ergonomic! One remaining question: can we test the full matrix of possible enabled features in CI somehow? (Perhaps running your newly-added script, or something?)

      I think it's going to be easy to miss out testing one of the runtime/TLS-library versions while developing (not to mention time-consuming, given how long things take to compile...), which we probably want to avoid.

    • Opened #303 (closed) for the CI matrix issue, if that's okay?

    • Please register or sign in to reply
  • Nick Mathewson added 1 commit

    added 1 commit

    Compare with previous version

  • Nick Mathewson added 1 commit

    added 1 commit

    • 9f3ad85d - Document why {current,create}_runtime are type-erased

    Compare with previous version

  • mentioned in issue #303 (closed)

  • Hi! I've taken some of your suggestions, opened a couple of tickets, changed documentation, and have a question above about naming. Back to you!

  • eta approved this merge request

    approved this merge request

  • eta enabled an automatic merge when the pipeline for 9f3ad85d succeeds

    enabled an automatic merge when the pipeline for 9f3ad85d succeeds

  • merged

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading