Skip to content
Snippets Groups Projects

maint: Add exclusion feature to `fixup-features`

Merged Clara Engler requested to merge cve/arti:dev/cve/fixup-features into main
3 unresolved threads
2 files
+ 15
4
Compare changes
  • Side-by-side
  • Inline
Files
2
+ 1
1
@@ -50,7 +50,7 @@ to make sure we aren't going to break our users.
Note: fixup-features should be run with the top-level Cargo.toml
as an argument:
```
cargo run -p fixup-features Cargo.toml
cargo run -p fixup-features -- --exclude examples/ --exclude maint/ Cargo.toml
    • Comment on lines -53 to +53
      Maintainer

      I think it would be helpful to also document this flag in the "To use" section of the docs in maint/fixup-features/src/main.rs.

    • Comment on lines -53 to +53
      Maintainer

      I think it should also be documented somewhere that this compares the strings to the workspace member strings and not the paths, so that someone doesn't use --exclude ./examples/ or something similar.

      • Author Developer

        The --help overview says <PREFIX1> and <PREFIX2>. I am not sure if this is enough for implying that it is string based though, but personally I interpret anything that is not <PATH> or <FILE> as something string based.

        Maybe <PATTERN> is a good alternative though?

      • Maintainer

        Okay, I think PREFIX is better than PATTERN here. I'm of the opinion that more documentation is always better :)

      • Please register or sign in to reply
Please register or sign in to reply
```
6. Does `maint/semver-checks "arti-v$LAST_VERSION"` find any issues
Loading