Ticket 17621.

In dirserv_compute_performance_thresholds, we allocate arrays based
on the length of 'routers', a list of routerinfo_t, but loop over
the nodelist. The 'routers' list may be shorter when relays were
filtered by routers_make_ed_keys_unique, leading to an out-of-bounds
write on directory authorities.

This bug was originally introduced in 26e89742, but it doesn't look
possible to trigger until routers_make_ed_keys_unique was introduced
in 13a31e72.

Fixes bug 19032; bugfix on tor 0.2.8.2-alpha.

Comment-only change

This reverts commit 92d7ee08.

Closes ticket 18761.

Also fix a whitespace issue.

This makes our compilation options checks in autoconf work better on
systems that already define _FORTIFY_SOURCE.

Fixes at least one case of bug 18841; bugfix on 0.2.3.17-beta. Patch
from "trudokal".

Previously, we were using the generic schedule for some downloads,
and the consensus schedule for others.

Resolves ticket 18816; fix on fddb814f in 0.2.4.13-alpha.

Fixes bug 19008. bugfix on 0.2.7.3-rc

This is an merge of maint-0.2.7 as an "ours" merge to avoid taking the
cherry-picked fix of 18490

teor (Tim Wilson-Brown) authored 8 years ago and Nick Mathewson committed 8 years ago

No behavioural change

This makes the use of the node explicit in the function, rather
than hiding the node lookup in fascist_firewall_allows_rs.

teor (Tim Wilson-Brown) authored 8 years ago and Nick Mathewson committed 8 years ago

Variable rename only

teor (Tim Wilson-Brown) authored 8 years ago and Nick Mathewson committed 8 years ago

This makes sure clients will only select relays which support
begindir over ORPort.

teor (Tim Wilson-Brown) authored 8 years ago and Nick Mathewson committed 8 years ago

This improves client anonymity and avoids directory header tampering.
The extra load on the authorities should be offset by the fallback
directories feature.

This also simplifies the fixes to #18809.

Delete an unnecessary check for non-preferred IP versions.

Allows clients which can't reach any directories of their
preferred IP address version to get directory documents.

Patch on #17840 in 0.2.8.1-alpha.

teor (Tim Wilson-Brown) authored 8 years ago and Nick Mathewson committed 8 years ago

After #17840 in 0.2.8.1-alpha, we incorrectly chose an IPv4
address for all DIRIND_ONEHOP directory connections,
even if the routerstatus didn't have an IPv4 address.

This likely affected bridge clients with IPv6 bridges.

Resolves #18921.