Coccinelle doesn't understand it when we use "==" and "!=" and so on as
arguments to macros.  To solve this, we prefer OP_EQ, OP_NE, and so
on.

This commit is automatically generated by running
./scripts/coccinelle/test_operator_cleanup over all of the source
code in src.

Note that this header file behaves a bit strangely.  It is used by
coccinelle just for the purpose of knowing how to parse
difficult-to-parse stuff.  It doesn't need to produce good C -- just
grammatical C.

spatch can let us know whether a file has parsed "perfectly" or
not.  The more perfect it parses, the likelier any semantic patches
are to apply.  I've used this script to identify problem areas in
our code.

It's a bit tricky to remember the right incantation to get the
proper include paths and incantations for coccinelle, but without
it, coccinelle is less effective at parsing our C.

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

See also ticket 31654.

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

Here we make it clear we're only looking at listable variable names,
not at whether the variables themselves are gettable.

Also, remove an extraneous h.

(This commit is not a fixup, because of rebase conflicts.)

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

(This option tests our existing behavior, not necessarily the most
sensible behavior.)

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

The old names remain as #defines that cause variables to get one or
more flags.

Now every flag-testing function in confparse.c tests exactly one flag.

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

Since the flags are now stored with compatible numbering, we can
just OR them together and see whether the flag we want is in the
result.

(Net code removal!)

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

Using a bitfield here will enable us to unify the var_type_def_t flags
with the config_var_t flags.

(This commit does not yet do that unification, and does not yet
rename or refactor any flags.  It only changes booleans into bits.)

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

Previously they checked the individual flags inside var_type_def_t;
now they call the appropriate var_type_is_*() functions.

(These functions will be removed entirely by the end of this branch.)

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

Don't use "derived" directly, but check its implications for listing
and copying.

Nick Mathewson authored 5 years ago and David Goulet committed 5 years ago

We had though to make all obsolete and invisible variables
ungettable, so that GETCONF would reject them.  But it turns out
that this isn't the current behavior of GETCONF with those
variables.  So for now, I'm leaving the current behavior unchanged.
(See ticket 31647 for a proposal to change the behavior.)

Part of 31615.

Merged modified lines from bug31615_041, and unmodified lines
from master.