Missing features on first-time launch in esr91
Tor Browser 11.0a9 seems to be missing key features on initial launch after a clean install, including (but probably not limited to):
- The
torconnectbuttons: esr91-mac-torconnect-buttons-bug -
about:preferences#tor: esr91-mac-tor-settings-bug - new-identity functionality: esr91-mac-new-identity-bug
The bug appears to clear itself after restarting the app, and everything works as expected. Sometimes it requires multiple restarts.
Activity
added Next label
It seems to clear itself after relaunching the app one or multiple times, and doesn't reoccur thereafter.
Edited by donutsmentioned in merge request tpo/web/tpo!140 (merged)
It seems to clear itself after relaunching the app one or multiple times, and doesn't reoccur thereafter.
I also get the
torconnect-buttonsmissing on Windows - it happens when I cold-boot TB 100% reliably - so some sort of timing issue? I can reproduce at will. I do have thetor-settingspage but minus the connect button
anyway, here's a console screen diff
-
@sysrqb umm, not so fast there young man .. here is one without
tor.exeand the cpu gets a thrashing
Seems like not (2) or (3) - I hit this while debugging another issue...:
CommandLine="C:\Users\matthew_finkel\Desktop\Tor Browser\Browser\TorBrowser\Tor\tor.exe" --defaults-torrc "C:\Users\matthew_finkel\Desktop\Tor Browser\Browser\TorBrowser\Data\Tor\torrc-defaults" -f "C:\Users\matthew_finkel\Desktop\Tor Browser\Browser\TorBrowser\Data\Tor\torrc" DataDirectory "C:\Users\matthew_finkel\Desktop\Tor Browser\Browser\TorBrowser\Data\Tor" ClientOnionAuthDir "C:\Users\matthew_finkel\Desktop\Tor Browser\Browser\TorBrowser\Data\Tor\onion-auth" GeoIPFile "C:\Users\matthew_finkel\Desktop\Tor Browser\Browser\TorBrowser\Data\Tor\geoip" GeoIPv6File "C:\Users\matthew_finkel\Desktop\Tor Browser\Browser\TorBrowser\Data\Tor\geoip6" HashedControlPassword 16:b18975b22b17e0c160ffc9650ff6f27b86582fecfdbc72b1ff419f9b16 +__ControlPort 9151 +__SocksPort "127.0.0.1:9150 ExtendedErrors IPv6Traffic PreferIPv6 KeepAliveIsolateSOCKSAuth" __OwningControllerProcess 5152 DisableNetwork 1And torbutton's state is reasonable:
We could hit this if Tor Launcher hits it's 5 minute time out, but I did not see that happen, and that should cause obvious error messages which I did not see. However, I did see a temporary hang of ~30 second at startup where the browser was completely frozen, but then it recovered and showed a broken
about:torconnect.I also killed the tor process, so I could get a look at tor launcher's state:
The fact that
mDidConnectToTorControlPortistruemeans thatthis.mObsSvc.notifyObservers(null, "TorProcessIsReady", null);should've been called, and that means thatTorConnectshould've moved into theConfiguringstate.mentioned in merge request tor-launcher!15 (merged)
mentioned in issue #40716 (closed)
-
A Win7 user on IRC has reported experiencing something very similar:
> Whenever I start the tor browser (on windows 7) it hangs on the 'Connect to tor' screen. > the 'Always connect automatically' box is shown (ticked), but NOT the [Connect] button, and it doesn't connect > I have found a workaround as follows. > If I manually edit prefs.js and set 'sanity-test.webrender.force-disabled' to true, then the tor browser will run and connect as usual. > This value however is always set back to false when the browser is closed. This started happening around 20th Nov. > ...and i've seen no error messages. It just hangs. > one other bit of possibly pertinent info.. I use the Windows 7 system always via a 'remote utilities' remote login. > the system is on the local gigabit network, but in another room. > I figured it out first by installing a fresh copy of the tor browser, and then by a LOT of trial and error. An initial install works, but only the fist time. > so i then wrote a script to reset all files back to as-installed. (mostly deletion of cache dirs etc). and prefs.js... > i found just deleting prefs.js fixed the issue, so then I isolated the issue to this specific setting within prefs.jsI confirmed with the user that they are indeed referring to the pre-connection
Connect to Torscreen – rather thanEstablishing a Connection– when they describe the connection hanging. changed milestone to %Tor Browser: 11.0 Issues with previous release
@thorin can you still reproduce this? If so would you mind posting the entire console log?
@duncan the symptoms you're seeing when setting a bad proxy is unrelated and easy enough to fix (the TorProtocolService.writeSettings() call is throwing which prevents the subsequent notification topic from going out so TorConnect is left waiting).
-
entire console log, yes I can reproduce at will cuz I am thorin :)
this is the one with
tor.exerunningclick me for details
TorSettings: loadFromPrefs() TorSettings.jsm:516:21 TorConnect: Init TorConnect.jsm:238:21 TorSettings: observed profile-after-change TorSettings.jsm:321:21 TorConnect: observed profile-after-change TorConnect.jsm:245:21 TorConnect: observing topic 'TorBootstrapStatus' TorConnect.jsm:257:33 TorConnect: observing topic 'TorBootstrapError' TorConnect.jsm:257:33 TorConnect: observing topic 'TorProcessExited' TorConnect.jsm:257:33 TorConnect: observing topic 'TorLogHasWarnOrErr' TorConnect.jsm:257:33 TorConnect: observing topic 'torsettings:ready' TorConnect.jsm:257:33 [12-08 14:21:53] Torbutton NOTE: Initializing security-prefs.js [12-08 14:21:53] Torbutton NOTE: security-prefs.js initialization complete Unexpected event profile-after-change URLQueryStrippingListService.jsm:224 TorSettings: observed TorProcessIsReady TorSettings.jsm:321:21 TorSettings: applySettings() TorSettings.jsm:651:21 Content Security Policy: Couldn’t parse invalid host 'wasm-eval' Bootstrapped manifest not allowed to use 'resource' directive. chrome.manifest:2 NS_ERROR_CONNECTION_REFUSED: Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIScriptableInputStream.available] tor-control-port.js:81 NS_ERROR_CONNECTION_REFUSED: Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIOutputStream.write] tor-control-port.js:117 NS_ERROR_CONNECTION_REFUSED: Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIScriptableInputStream.available] tor-control-port.js:81 NS_ERROR_CONNECTION_REFUSED: Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIOutputStream.write] tor-control-port.js:117 NS_ERROR_CONNECTION_REFUSED: Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIScriptableInputStream.available] tor-control-port.js:81 NS_ERROR_CONNECTION_REFUSED: Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIOutputStream.write] tor-control-port.js:117 NS_ERROR_CONNECTION_REFUSED: Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIScriptableInputStream.available] tor-control-port.js:81 NS_ERROR_CONNECTION_REFUSED: Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIOutputStream.write] tor-control-port.js:117 TorConnect: will load after bootstrap => [about:tor] TorConnect.jsm:493:21 Could not load engine blockchair-onion@search.mozilla.org: Error: Extension is invalid SearchService.jsm:609:17 1638973317293 addons.webextension.<unknown> ERROR Loading extension 'null': Reading manifest: Error processing chrome_settings_overrides.search_provider.search_form: String "http://blkchairbknpn73cfjhevhla7rkp4ed5gg2knctvv7it4lioy22defid.onion/search/?q={searchTerms}" must match /^(https:\/\/|http:\/\/(localhost|127\.0\.0\.1|\[::1\])(:\d*)?(\/|$)).*$/ Log.jsm:723 [12-08 14:21:57] Torbutton NOTE: no SOCKS credentials found for current document. Error: Can't find profile directory. XULStore.jsm:66:15 [12-08 14:21:57] Torbutton WARN: Local Tor check: unexpected GETINFO response: 250 OK TypeError: Cc[aContract] is undefined XPCOMUtils.jsm:161:9 Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. store.js:135 Unchecked lastError value: Error: ID already exists: noscript-ctx-menu main.js:44 NetworkError when attempting to fetch resource. IgnoreLists.jsm:90:10 NetworkError when attempting to fetch resource. ASRouter.jsm:110:8 Key event not available on GTK2: key=“u” modifiers=“accel shift” id=“torbutton-new-identity-key” browser.xhtml Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox” browser.xhtml TypeError: window.RFPHelper is undefined2 RFPHelperParent.jsm:29:7Edited by Thorin -
Loggssss
TorSettings: loadFromPrefs() TorSettings.jsm:516:21 TorConnect: Init TorConnect.jsm:238:21 Content Security Policy: Couldn’t parse invalid host 'wasm-eval' 2 TorSettings: observed profile-after-change TorSettings.jsm:321:21 TorConnect: observed profile-after-change TorConnect.jsm:245:21 TorConnect: observing topic 'TorBootstrapStatus' TorConnect.jsm:257:33 TorConnect: observing topic 'TorBootstrapError' TorConnect.jsm:257:33 TorConnect: observing topic 'TorProcessExited' TorConnect.jsm:257:33 TorConnect: observing topic 'TorLogHasWarnOrErr' TorConnect.jsm:257:33 TorConnect: observing topic 'torsettings:ready' TorConnect.jsm:257:33 [12-08 14:35:36] Torbutton NOTE: Initializing security-prefs.js [12-08 14:35:36] Torbutton NOTE: security-prefs.js initialization complete Unexpected event profile-after-change URLQueryStrippingListService.jsm:224 NS_ERROR_CONNECTION_REFUSED: Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIScriptableInputStream.available] tor-control-port.js:81 NS_ERROR_CONNECTION_REFUSED: Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIOutputStream.write] tor-control-port.js:117 Content Security Policy: Couldn’t parse invalid host 'wasm-eval' 2 Bootstrapped manifest not allowed to use 'resource' directive. chrome.manifest:2 [Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 707" data: no] 5 L10nRegistry.jsm:707:19 [Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 707" data: no] 13 L10nRegistry.jsm:707:19 TorConnect: will load after bootstrap => [about:tor] TorConnect.jsm:493:21 [12-08 14:35:37] Torbutton WARN: Local Tor check: unexpected GETINFO response: 250 OK [12-08 14:35:37] Torbutton NOTE: no SOCKS credentials found for current document. 1638974137556 addons.webextension.<unknown> ERROR Loading extension 'null': Reading manifest: Error processing chrome_settings_overrides.search_provider.search_form: String "http://blkchairbknpn73cfjhevhla7rkp4ed5gg2knctvv7it4lioy22defid.onion/search/?q={searchTerms}" must match /^(https:\/\/|http:\/\/(localhost|127\.0\.0\.1|\[::1\])(:\d*)?(\/|$)).*$/ Log.jsm:723 Could not load engine blockchair-onion@search.mozilla.org: Error: Extension is invalid SearchService.jsm:609:17 Error: Can't find profile directory. XULStore.jsm:66:15 NetworkError when attempting to fetch resource. IgnoreLists.jsm:90:10 TypeError: Cc[aContract] is undefined XPCOMUtils.jsm:161:9 BackgroundUpdate: _reasonsToNotScheduleUpdates: Failed to check for Maintenance Service Registry Key: [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIUpdateProcessor.getServiceRegKeyExists]" nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)" location: "JS frame :: resource://gre/modules/BackgroundUpdate.jsm :: _reasonsToNotScheduleUpdates :: line 243" data: no] BackgroundUpdate.jsm:245 NetworkError when attempting to fetch resource. ASRouter.jsm:110:8 Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. store.js:135 Use of nsIFile in content process is deprecated. 24 NetUtil.jsm:253:8 -
@duncan: I've uploaded a build with some console traces in those failing control port functions:
If you could re-run with this build and share the logs that'd be swell :)
assigned to @richard
-
Done! Extra logs:
Expand to view logs
TorConnect: Init TorConnect.jsm:238:21 TorConnect: observed profile-after-change TorConnect.jsm:245:21 TorConnect: observing topic 'TorBootstrapStatus' TorConnect.jsm:257:33 TorConnect: observing topic 'TorBootstrapError' TorConnect.jsm:257:33 TorConnect: observing topic 'TorProcessExited' TorConnect.jsm:257:33 TorConnect: observing topic 'TorLogHasWarnOrErr' TorConnect.jsm:257:33 TorConnect: observing topic 'torsettings:ready' TorConnect.jsm:257:33 TorSettings: observed profile-after-change TorSettings.jsm:321:21 [12-09 16:00:25] Torbutton NOTE: Initializing security-prefs.js [12-09 16:00:25] Torbutton NOTE: security-prefs.js initialization complete Unexpected event profile-after-change URLQueryStrippingListService.jsm:224 console.trace() tor-control-port.js:106:11 asyncSocket resource://torbutton/modules/tor-control-port.js:106 controlSocket resource://torbutton/modules/tor-control-port.js:284 controller resource://torbutton/modules/tor-control-port.js:699 newTorController resource://torbutton/modules/tor-control-port.js:759 controller resource://torbutton/modules/tor-control-port.js:769 _openAuthenticatedConnection jar:file:///Applications/Tor Browser.app/Contents/Resources/browser/omni.ja!/chrome/torlauncher/components/tl-protocol.js:778 _getConnection jar:file:///Applications/Tor Browser.app/Contents/Resources/browser/omni.ja!/chrome/torlauncher/components/tl-protocol.js:759 TorHaveControlConnection jar:file:///Applications/Tor Browser.app/Contents/Resources/browser/omni.ja!/chrome/torlauncher/components/tl-protocol.js:717 observe jar:file:///Applications/Tor Browser.app/Contents/Resources/browser/omni.ja!/chrome/torlauncher/components/tl-process.js:226 console.trace() tor-control-port.js:74:11 pumpInputStream resource://torbutton/modules/tor-control-port.js:74 asyncSocket resource://torbutton/modules/tor-control-port.js:113 controlSocket resource://torbutton/modules/tor-control-port.js:284 controller resource://torbutton/modules/tor-control-port.js:699 newTorController resource://torbutton/modules/tor-control-port.js:759 controller resource://torbutton/modules/tor-control-port.js:769 _openAuthenticatedConnection jar:file:///Applications/Tor Browser.app/Contents/Resources/browser/omni.ja!/chrome/torlauncher/components/tl-protocol.js:778 _getConnection jar:file:///Applications/Tor Browser.app/Contents/Resources/browser/omni.ja!/chrome/torlauncher/components/tl-protocol.js:759 TorHaveControlConnection jar:file:///Applications/Tor Browser.app/Contents/Resources/browser/omni.ja!/chrome/torlauncher/components/tl-protocol.js:717 observe jar:file:///Applications/Tor Browser.app/Contents/Resources/browser/omni.ja!/chrome/torlauncher/components/tl-process.js:226 NS_ERROR_CONNECTION_REFUSED: Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIScriptableInputStream.available] tor-control-port.js:84 NS_ERROR_CONNECTION_REFUSED: Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED) [nsIOutputStream.write] tor-control-port.js:124 NetworkError when attempting to fetch resource. RemoteSettingsClient.jsm:413:14 Content Security Policy: Couldn’t parse invalid host 'wasm-eval' Bootstrapped manifest not allowed to use 'resource' directive. chrome.manifest:2 [Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 707" data: no] 5 L10nRegistry.jsm:707:19 Content Security Policy: Couldn’t parse invalid host 'wasm-eval' [Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 707" data: no] 13 L10nRegistry.jsm:707:19 TorConnect: will load after bootstrap => [about:tor] TorConnect.jsm:493:21 Content Security Policy: Couldn’t parse invalid host 'wasm-eval' console.trace() tor-control-port.js:106:11 asyncSocket resource://torbutton/modules/tor-control-port.js:106 controlSocket resource://torbutton/modules/tor-control-port.js:284 controller resource://torbutton/modules/tor-control-port.js:699 newTorController resource://torbutton/modules/tor-control-port.js:759 controller resource://torbutton/modules/tor-control-port.js:779 start chrome://torbutton/content/tor-circuit-display.js:474 unbindPref chrome://torbutton/content/tor-circuit-display.js:488 update resource://torbutton/modules/utils.js:28 bindPref resource://torbutton/modules/utils.js:36 bindPrefAndInit resource://torbutton/modules/utils.js:46 setupDisplay chrome://torbutton/content/tor-circuit-display.js:488 torbutton_init chrome://torbutton/content/torbutton.js:242 torbutton_new_window chrome://torbutton/content/torbutton.js:1281 console.trace() tor-control-port.js:74:11 pumpInputStream resource://torbutton/modules/tor-control-port.js:74 asyncSocket resource://torbutton/modules/tor-control-port.js:113 controlSocket resource://torbutton/modules/tor-control-port.js:284 controller resource://torbutton/modules/tor-control-port.js:699 newTorController resource://torbutton/modules/tor-control-port.js:759 controller resource://torbutton/modules/tor-control-port.js:779 start chrome://torbutton/content/tor-circuit-display.js:474 unbindPref chrome://torbutton/content/tor-circuit-display.js:488 update resource://torbutton/modules/utils.js:28 bindPref resource://torbutton/modules/utils.js:36 bindPrefAndInit resource://torbutton/modules/utils.js:46 setupDisplay chrome://torbutton/content/tor-circuit-display.js:488 torbutton_init chrome://torbutton/content/torbutton.js:242 torbutton_new_window chrome://torbutton/content/torbutton.js:1281 console.trace() tor-control-port.js:106:11 asyncSocket resource://torbutton/modules/tor-control-port.js:106 controlSocket resource://torbutton/modules/tor-control-port.js:284 controller resource://torbutton/modules/tor-control-port.js:699 newTorController resource://torbutton/modules/tor-control-port.js:759 controller resource://torbutton/modules/tor-control-port.js:769 torbutton_send_ctrl_cmd chrome://torbutton/content/torbutton.js:355 torbutton_local_tor_check chrome://torbutton/content/torbutton.js:800 torbutton_do_tor_check chrome://torbutton/content/torbutton.js:776 torbutton_tor_check_ok chrome://torbutton/content/torbutton.js:946 getChromeData chrome://torbutton/content/torbutton.js:286 updateAllOpenPages chrome://torbutton/content/torbutton.js:274 torbutton_init_user_manual_links chrome://torbutton/content/torbutton.js:1452 update resource://torbutton/modules/utils.js:28 bindPref resource://torbutton/modules/utils.js:36 bindPrefAndInit resource://torbutton/modules/utils.js:46 torbutton_init_user_manual_links chrome://torbutton/content/torbutton.js:1450 torbutton_init chrome://torbutton/content/torbutton.js:248 torbutton_new_window chrome://torbutton/content/torbutton.js:1281 console.trace() tor-control-port.js:74:11 pumpInputStream resource://torbutton/modules/tor-control-port.js:74 asyncSocket resource://torbutton/modules/tor-control-port.js:113 controlSocket resource://torbutton/modules/tor-control-port.js:284 controller resource://torbutton/modules/tor-control-port.js:699 newTorController resource://torbutton/modules/tor-control-port.js:759 controller resource://torbutton/modules/tor-control-port.js:769 torbutton_send_ctrl_cmd chrome://torbutton/content/torbutton.js:355 torbutton_local_tor_check chrome://torbutton/content/torbutton.js:800 torbutton_do_tor_check chrome://torbutton/content/torbutton.js:776 torbutton_tor_check_ok chrome://torbutton/content/torbutton.js:946 getChromeData chrome://torbutton/content/torbutton.js:286 updateAllOpenPages chrome://torbutton/content/torbutton.js:274 torbutton_init_user_manual_links chrome://torbutton/content/torbutton.js:1452 update resource://torbutton/modules/utils.js:28 bindPref resource://torbutton/modules/utils.js:36 bindPrefAndInit resource://torbutton/modules/utils.js:46 torbutton_init_user_manual_links chrome://torbutton/content/torbutton.js:1450 torbutton_init chrome://torbutton/content/torbutton.js:248 torbutton_new_window chrome://torbutton/content/torbutton.js:1281 SearchSettings: get: No settings file exists, new profile? DOMException: Could not open the file at /Users/duncan/Library/Application Support/TorBrowser-Data/Browser/0pot01vd.default/search.json.mozlz4 SearchSettings.jsm:108:18 [12-09 16:00:26] Torbutton WARN: Local Tor check: unexpected GETINFO response: <details><summary>click me for details</summary><p> 250 OK [12-09 16:00:26] Torbutton NOTE: no SOCKS credentials found for current document. Error: Can't find profile directory. XULStore.jsm:66:15 Error: Could not get children of file(/Users/duncan/Library/Application Support/TorBrowser-Data/Browser/0pot01vd.default/thumbnails) because it does not exist PromiseWorker.jsm:106 Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. store.js:135 Could not load engine blockchair-onion@search.mozilla.org: Error: Extension is invalid SearchService.jsm:609:17 1639065626562 addons.webextension.<unknown> ERROR Loading extension 'null': Reading manifest: Error processing chrome_settings_overrides.search_provider.search_form: String "http://blkchairbknpn73cfjhevhla7rkp4ed5gg2knctvv7it4lioy22defid.onion/search/?q={searchTerms}" must match /^(https:\/\/|http:\/\/(localhost|127\.0\.0\.1|\[::1\])(:\d*)?(\/|$)).*$/ Log.jsm:723 NetworkError when attempting to fetch resource. RemoteSettingsClient.jsm:413:14 BackgroundUpdate: _reasonsToNotScheduleUpdates: Failed to check for Maintenance Service Registry Key: [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIUpdateProcessor.getServiceRegKeyExists]" nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)" location: "JS frame :: resource://gre/modules/BackgroundUpdate.jsm :: _reasonsToNotScheduleUpdates :: line 243" data: no] BackgroundUpdate.jsm:245 NetworkError when attempting to fetch resource. 3 RemoteSettingsClient.jsm:413:14Edited by donuts
-
Merge request incoming!
For posterity:
<donuts> any idea why this only seemed to become an issue in esr91? <GeKo> yeah, that would be one of my questions, too :) <richard> yeah <richard> so part of the work for esr91 was converting synchrynous socket IO to async <richard> we used to have 2 tor-controller implementations, one in tor-launcher and one in torbutton <richard> i guess the torbutton implementation looked easier to convert so we converted it to use async (or it already was, not sure on the details here) <richard> so now tor-launcher and torbutton now both use the torbutton control port implementation <richard> the problem is that almost every system using the control port expect tor to be running by the time they are running <richard> well taht wasn't the root problem, but that was some fallout i've also had to fix <richard> the 'root' problem is that if tor launched slowly, tor-launcher's initial connection attempt to the control port socket would fail <richard> we had naively passed in a simple 'throw error' error handler into the implementation, thinking that exception would bubble up in the event of a problem, signaling tor-launcher to try again later <richard> unfortunately, that exception was not being thrown up the same call stack, because the handler got passed into a separate native calling context <richard> so the exception would just throw and print to console, and our 'await torcontroller' call would just sit and block indefinitely <richard> but fixing that exposed the above mentioned 'all our code expects tor to be running when we make our control port' problem <richard> so i've also had to go an async'ify various other systems as well <richard> but now we can arbitrarily block tor from launching and everythign figures their shit out so yay mentioned in merge request tor-launcher!17 (closed)
mentioned in merge request torbutton!77 (closed)
-
@duncan, @thorin Test builds! Includes the above patches to tor-launcher and torbutton.
- macOS : https://people.torproject.org/~richard/builds/tor-browser/bug_40679/TorBrowser-11.0.3-osx64_en-US.dmg
- Windows : https://people.torproject.org/~richard/builds/tor-browser/bug_40679/torbrowser-install-win64-11.0.3_en-US.exe
For run, you can also exacerbate the tor slow launch by adding
extensions.torlauncher.launch_delayas a Number pref inabout:config, the value being number of milliseconds to delay before initiating the tor daemon launch.Edited by morgan -
On first run (before profile is created, the launch was instantaneous and the connect button was there)
Setting the pref to e.g. a 5 second delay, simulated the long wait for a connect button
no console errors(edit buttin shows up, I can connect, I can browser). I'll check later after a reboot, to see what happens without the artificial delayhere's the log with 5 sec delay with timestamps
`
18:21:34.034 TorSettings: loadFromPrefs() TorSettings.jsm:516:21 18:21:34.038 TorConnect: Init TorConnect.jsm:238:21 18:21:34.145 TorSettings: observed profile-after-change TorSettings.jsm:321:21 18:21:34.145 TorConnect: observed profile-after-change TorConnect.jsm:245:21 18:21:34.145 TorConnect: observing topic 'TorBootstrapStatus' TorConnect.jsm:257:33 18:21:34.145 TorConnect: observing topic 'TorBootstrapError' TorConnect.jsm:257:33 18:21:34.145 TorConnect: observing topic 'TorProcessExited' TorConnect.jsm:257:33 18:21:34.145 TorConnect: observing topic 'TorLogHasWarnOrErr' TorConnect.jsm:257:33 18:21:34.145 TorConnect: observing topic 'torsettings:ready' TorConnect.jsm:257:33 18:21:34.155 [12-18 18:21:34] Torbutton NOTE: Initializing security-prefs.js 18:21:34.156 [12-18 18:21:34] Torbutton NOTE: security-prefs.js initialization complete 18:21:34.170 Unexpected event profile-after-change URLQueryStrippingListService.jsm:224 18:21:34.338 Content Security Policy: Couldn’t parse invalid host 'wasm-eval' 18:21:34.374 Bootstrapped manifest not allowed to use 'resource' directive. chrome.manifest:2 18:21:34.483 TorConnect: will load after bootstrap => [about:tor] TorConnect.jsm:493:21 18:21:34.620 Could not load engine blockchair-onion@search.mozilla.org: Error: Extension is invalid SearchService.jsm:609:17 18:21:34.620 1639851694620 addons.webextension.<unknown> ERROR Loading extension 'null': Reading manifest: Error processing chrome_settings_overrides.search_provider.search_form: String "http://blkchairbknpn73cfjhevhla7rkp4ed5gg2knctvv7it4lioy22defid.onion/search/?q={searchTerms}" must match /^(https:\/\/|http:\/\/(localhost|127\.0\.0\.1|\[::1\])(:\d*)?(\/|$)).*$/ Log.jsm:723 18:21:34.667 Error: Can't find profile directory. XULStore.jsm:66:15 18:21:34.954 Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. store.js:135 18:21:35.202 [12-18 18:21:35] TorLauncher NOTE: failed to open authenticated connection: [scrubbed] 18:21:36.265 [12-18 18:21:36] TorLauncher NOTE: failed to open authenticated connection: [scrubbed] 18:21:36.639 NetworkError when attempting to fetch resource. RemoteSettingsClient.jsm:413:14 18:21:36.816 NetworkError when attempting to fetch resource. IgnoreLists.jsm:90:10 18:21:37.380 [12-18 18:21:37] TorLauncher NOTE: failed to open authenticated connection: [scrubbed] 18:21:37.647 NetworkError when attempting to fetch resource. RemoteSettingsClient.jsm:413:14 18:21:38.584 [12-18 18:21:38] TorLauncher NOTE: failed to open authenticated connection: [scrubbed] 18:21:39.668 NetworkError when attempting to fetch resource. RemoteSettingsClient.jsm:413:14 18:21:39.820 TorSettings: observed TorProcessIsReady TorSettings.jsm:321:2118:21:39.820 TorSettings: applySettings() TorSettings.jsm:651:21 18:21:39.821 [12-18 18:21:39] TorLauncher NOTE: control connection is in use 2 18:21:39.822 TorConnect: observed TorBootstrapStatus TorConnect.jsm:245:21 18:21:39.822 TorConnect: observed TorBootstrapStatus topic while in state TorConnectState.Initial TorConnect.jsm:284:29 18:21:39.825 [12-18 18:21:39] Torbutton WARN: Local Tor check: unexpected GETINFO response: 250 OK 18:21:40.096 TorConnect: observed torsettings:ready TorConnect.jsm:245:21 18:21:40.097 TorConnect: beginConfigure() TorConnect.jsm:382:21 18:21:40.097 TorConnect: transitioning state from Initial to Configuring TorConnect.jsm:224:21 18:21:40.101 Tor NOTICE: DisableNetwork is set. Tor will not make or accept non-control network connections. Shutting down all existing connections. 18:21:41.673 NetworkError when attempting to fetch resource. RemoteSettingsClient.jsm:413:14 18:21:41.987 Key event not available on GTK2: key=“u” modifiers=“accel shift” id=“torbutton-new-identity-key” browser.xhtml 18:21:41.987 Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox” browser.xhtml) 18:21:43.056 TypeError: window.RFPHelper is undefined64 RFPHelperParent.jsm:29:7Edited by Thorin -
note to self and @duncan : it started downloading an app update once connected: so set
app.update.auto= false for this test build firstEdited by Thorin -
Tested around ~12 times each on an M1 running MacOS 12.0 & an Intel running MacOS 11.6. Didn't experience any issues save for the occasional ~0.5sec delay for the torconnect buttons to appear :)
@richard Let's follow-up on how to treat that delay in a separate ticket, yep?
mentioned in issue #40757 (closed)
mentioned in merge request torbutton!81 (merged)
mentioned in merge request tor-browser-build!394 (closed)
mentioned in issue tor-browser-build#40419 (closed)
mentioned in commit tor-browser-build@003cff75
mentioned in issue #40650 (closed)
-
@championquizzer Have you had any more reports of this bug recently (from users who are using up to date versions of Tor Browser)?
mentioned in issue #40922 (closed)
mentioned in issue #40726 (closed)
Please register or sign in to reply