Release-blocking TODO HS in tor-hsclient

Quoting the text of the TODO, generally. Ticking the box here means "resolved well enough for the release". In some cases, after consideration, we may tick the box here to say "unblock for the release", even without any code change.

MRs (to be merged, or replaced, or re-classified as nonblocking):

connect.rs:

  • TODO HS desc.intro_points() ought not to be able to be empty
  • TODO HS: make sure that we do the correct error recovery from the
  • TODO HS: Generate this more sensibly! (CircParameters) #935 (closed)
  • TODO HS is this right? make configurable? get from netdir? x4 (timeouts)

err.rs:

  • TODO HS this should be `Redacted<RelayIds>`, as per
  • TODO HS is this the right name for this variant? re Failed [1]
  • TODO HS is this the right name for this type? It's a very mixed bag, so maybe it is. re FailedAttemptError [1]
  • TODO HS: is even this too much leakage? re hsdir identity in failed download attempt

[1] as per !1228 (comment 2910294); I'm OK with it as-is, but I think @nickm might not be. @nickm, please either tick the boxes here or open a ticket for us to have the discussion in?

Edited by Ian Jackson