Obviously correct fix to rename_c_identifier.py.

Bugfix on 32237; not in any released version of tor.

Based on 8-space tabs, the git/less default.

Cleanup after 31919.

And print the spatch version and build details

Part of 31919.

And add it to check-local.

Part of 31919.

Bionic has a recent coccinelle version, which passes our CI tests.

But Bionic (and Xenial) cause permissions errors for chutney.
We'll fix those in 32240.

Part of 31919.

"ours" to avoid version bump.

This prevents a warning when building for 32-bit targets.

Fixes bug 32269; bug not in any released Tor.

Single hop rejection (POST and GET) for HS v3 descriptor now return a 503 code
which is more accurate code from dir-spec.txt and from other rejection case in
the code.

For instance if you are not a relay and you get a POST request, a 503 code is
sent back with a rejection message.

Part of #31958

Signed-off-by: David Goulet <dgoulet@torproject.org>

First, remove the HSDir mention which should not be in that generic function.
Second, move them to debug() level since they are possible error case.

Part of #31958

Signed-off-by: David Goulet <dgoulet@torproject.org>

Before inspecting the p_chan, we must check if the circuit is marked for close
because if it is the case, the channels are nullified from the circuit.

Several valid cases can mark the circuit for close of the directory
connection.

Fixes #31958

Signed-off-by: David Goulet <dgoulet@torproject.org>

Closes #32266

Signed-off-by: David Goulet <dgoulet@torproject.org>

hs_client_purge_state() and hs_cache_clean_as_client() can remove a descriptor
from the client cache with a NEWNYM or simply when the descriptor expires.

Which means that for an INTRO circuit being established during that time, once
it opens, we lookup the descriptor to get the IP object but hey surprised, no
more descriptor.

The approach here is minimalist that is accept the race and close the circuit
since we can not continue. Before that, the circuit would stay opened and the
client wait the SockTimeout.

Fixers #28970.

Signed-off-by: David Goulet <dgoulet@torproject.org>

This script should "pay for itself" if it prevents one bug caused by
careless search-replace-commit loops.

Part of 31919.

Part of 31919.

But only check modified files, which dramatically speeds up
check_cocci_parse.sh.

Part of 31919.

Check the tor-owned sources in an 0.3.5 directory layout, if no
files are provided on the command line.

Part of 31919.

Add check_cocci_parse.sh, which is a thin wrapper around
try_parse.sh. Add a default exceptions file, and use it in
check_cocci_parse.sh.

Part of 31919.

Part of 31919.

Set $TOR_COCCI_EXCEPTIONS_FILE to the name of an exceptions file,
containing a list of filename patterns matched by 'grep -f'.

Part of 31919.

"ours" to avoid version bump.